element-hq / element-hq/element-web

Shield of "Not Trusted" modal is hard to see on dark theme

Open
#15,354 0 comments 0 reactions 0 assignees View on GitHub
A-Appearance A-E2EE O-Occasional S-Tolerable T-Defect X-Needs-Design
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Description

![image](https://user-images.githubusercontent.com/1342360/94835412-940c8f80-0409-11eb-9c97-83ffb692314e.png)

The black shield is difficult to see on the dark theme. With the light theme it's fine:

![image](https://user-images.githubusercontent.com/1342360/94835500-b1415e00-0409-11eb-8899-5452ea2cdce2.png)

Seems like this image doesn't change based on the theme.

### Steps to reproduce

- Switch to the dark theme
- Try to verify a device, either your own or someone else's
- Squint

Logs being sent: no

### Version information

- **Platform**: desktop
- **OS**: Manjaro Linux
- **Version**: Element Nightly version 2020091301

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue in the desktop client by switching to the dark theme and opening the device-verification flow until the “Not Trusted” modal appears. Locate the shield image or asset used by that modal and verify the result against both dark and light themes; done means the shield is clearly visible in dark mode without harming the light theme.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.