element-hq / element-hq/element-web

Mention or username pill without avatar is too narrow, cuts off username, and is vertically mis-aligned …

Open
#15,081 2 comments 0 reactions 0 assignees View on GitHub
T-Defect
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

When turning off `Show avatars in user and room mentions` in Element, the surrounding background of resulting mentions or username pills, are too narrow and cut off the username to the left …

Screenshot 2020-09-02 at 08 21 34

Also username and the text don’t share the same baseline, i.e. they are vertically not aligned.

This could be fixed rather elegantly with removing the (in my opinion) unnecessary background color, setting the line-height and vertical-alignment to default and e.g. using text-decoration underline for the pill …

Screenshot 2020-09-02 at 08 25 08

PS: Which would also work pretty well for mentions or username pills WITH the avatar … and would be way better for readability and textflow, see also: https://github.com/vector-im/element-web/issues/14794

Screenshot 2020-09-02 at 08 31 28

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.