element-hq / element-hq/element-web

"Restore from backup" button doesn't prompt for SSSS, which is surprising

Open
#13,209 1 comment 0 reactions 0 assignees View on GitHub
T-Defect
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

Clicking on "restore from backup" these days, if you have your backup key cached locally, goes and pulls down all the keys from the server without prompting further.

This is a bit surprising - when is a user meant to actually use this button? Should we hide it if the backup key is already cached?

Contributor guide

Open the contributing guide

Research direction

Start by locating the "Restore from backup" button and the SSSS restore flow in the TypeScript client. Reproduce the behavior with a locally cached backup key, then inspect how the flow decides whether to prompt or retrieve keys. Done should match an explicitly agreed behavior for cached keys, with coverage for both cached and uncached cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.