element-hq / element-hq/element-meta

[Story] Username disambiguation

Open
#2,269 0 comments 0 reactions 1 assignee View on GitHub

@VolkerJunginger is already working on this.

Since Jan 15, 2024.

App: ElementX Android App: ElementX iOS T-Epic T-User Story Team: Element X Platform
Dominant language
No language data
Stars
112
Forks
26
Avg merge
6h 6m
Merged PRs (30d)
4

Description

Description
  • As a user I want my username and the username of other users to not be spoofed by other malicious users by having the user ID being shown if multiple users in the same room share the same display name, so that I can always understand who really is the user having that display name, and if they are pretending to be someone else.
Acceptance criteria
  • If multiple users have the same display name in a room we should display also their user id in the timeline and in notifications
  • The additional user ID displayed in the timeline should probably be displayed with a slightly different format than the display name, this is already done on web, this is for security reason to avoid users spoofing also the presence of the user ID in their name to circumvent the ambiguity check.
Leads
  • Tech: @Velin92
  • Design: @amshakal
Size estimate

S

Dependencies
  • None
Out of scope
  • Nothing
Open questions
### Questions
[ ] - how to display the additional user ID in the timeline?
[ ] - How to display it in the notifications? (since we can't do different formatting there)
Subtasks
### Android
- [ ] https://github.com/element-hq/element-x-android/pull/2221
- [ ] https://github.com/element-hq/element-x-android/pull/2295
### iOS
### Rust
### Other
Sign-off
Android
  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion
iOS
  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.