element-hq / element-hq/element-meta

should we pin non-self-signed TLS certs?

Open
#1,142 1 comment 1 reaction 0 assignees View on GitHub
P2 Security T-Defect
Dominant language
No language data
Stars
112
Forks
25
Avg merge
6h 6m
Merged PRs (30d)
4

Description

Much drama over at https://medium.com/@pepelephew/how-to-intercept-all-wire-voice-and-video-calls-13da1246675c#.aa9txx9r1 because Wire don't pin their TLS certs (and also don't seem to put their VoIP signalling over axolotl). AIUI this means that an attacker can load a fake CA root cert onto a device, serve up bogus DNS with a bogus cert, and happily MITM away. Given we support cert pinning for self-signed certs (on iOS & Android at least), should we also do so for CA-signed ones too?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.