element-hq / element-hq/element-ios

Localizable strings aren't reorderable

Open
#7,700 0 comments 0 reactions 0 assignees View on GitHub
O-Occasional S-Minor T-Defect
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

1. Get in a situation where these strings are displayed:
https://github.com/vector-im/element-ios/blob/94dc313aa880120be96fb2fe9dd11eb6fb7a84e9/Riot/Assets/en.lproj/Vector.strings#L1188-L1189
2. Change your language to Japanese
3. View the strings

### Outcome

#### What did you expect?
To see あなたの他のセッションに暗号鍵を再要求

#### What happened instead?
I get 暗号鍵を再要求 あなたの他のセッションに。

I'm seeing a lot of part1/part2 strings in that strings file, and I'd guess they all need to be reformatted in a way that lets translators reorder them.

### Your phone model

iPhone XS

### Operating system version

iOS 16.6.1

### Application version

Element 1.11.4

### Homeserver

matrix.org

### Will you send logs?

Yes

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.