element-hq / element-hq/element-ios

Localization of Set up cross-signing UI

Open
#7,586 2 comments 0 reactions 0 assignees View on GitHub
A-E2EE-Cross-Signing O-Frequent S-Minor T-Defect
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

String messages in module `Riot/Modules/Settings/Security/SecurityViewController.m` are not localized.

```
// Double confirmation
UIAlertController *alertController = [UIAlertController alertControllerWithTitle:@"Are you sure?" // TODO
message:@"Anyone you have verified with will see security alerts. You almost certainly don't want to do this, unless you've lost every device you can cross-sign from." // TODO
preferredStyle:UIAlertControllerStyleAlert];

[alertController addAction:[UIAlertAction actionWithTitle:@"Reset"
style:UIAlertActionStyleDefault
handler:^(UIAlertAction * action)
```

```
NSMutableString *mutableString = [@"Your account has a Secure Backup.\n" mutableCopy];

if (self.mainSession.crypto.backup.keyBackupVersion)
{
[mutableString appendString:@"\n\n⚠️ The key of your current Message backup is not in the Secure Backup. Restore it first (see below)."];
}
else
{
[mutableString appendString:@"\n\n⚠️ Consider create a Message Backup (see below)."];
}
}

if (!hasWarning)
{
[mutableString appendFormat:@"\n\nIf you are facing an issue, synchronise your Secure Backup."];
}
```

```
if (self.canSetupSecureBackup)
{
secureBackupInformation = [NSString stringWithFormat:@"No Secure Backup. Create one.\n-----\nKeys to back up: %@", recoveryService.secretsStoredLocally];
}
else
{
secureBackupInformation = [NSString stringWithFormat:@"No Secure Backup. Set up cross-signing first (see above)"];
}
```

```
if ([recoveryService hasSecretWithSecretId:secretId])
{
if ([recoveryService hasSecretLocally:secretId])
{
information = [NSString stringWithFormat:@"\n ✅ %@ is in the backup", secretName];
}
else
{
information = [NSString stringWithFormat:@"\n ⚠️ %@ is in the backup but not locally. Tap Synchronise", secretName];
*hasWarning |= YES;
}
}
else
{
if ([recoveryService hasSecretLocally:secretId])
{
information = [NSString stringWithFormat:@"\n ⚠️ %@ is not in the backup. Tap Synchronise", secretName];
*hasWarning |= YES;
}
}
```

### Your phone model

iPhone

### Operating system version

16.4

### Application version

Element 1.10.11

### Will you send logs?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.