element-hq / element-hq/element-ios

Use theme colors in rounded buttons disabled state

Open Beginner friendly
#7,395 0 comments 0 reactions 0 assignees View on GitHub
O-Occasional S-Minor T-Defect
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

Some rounded buttons doesn't use color from theme in Disabled state.

In some views, the green color of the button's labels is hard-coded into storyboards.

TODO : define title color for Disabled state from theme in RoundedButton.updateButtonStyle method.

Contributor guide

Open the contributing guide

Research direction

Start with the RoundedButton.updateButtonStyle method and inspect the storyboards where disabled button label colors are hard-coded. Trace how the theme supplies colors for the disabled state, then confirm that rounded buttons use the themed title color consistently in those views.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.