element-hq / element-hq/element-ios

Sharing menu allows selecting multiple rooms despite using radio buttons

Open
#6,703 1 comment 0 reactions 1 assignee Claimed by @rufuskahler View on GitHub
A-ShareExtension O-Frequent S-Tolerable T-Defect X-Needs-Design
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

1. Share content from iOS share menu, click "Element"
2. Seeing a long list of rooms, click by mistake on a random wrong room [_Whose content you do NOT want to share_]
3. Instead scrolling through the long list, enter the room name in the search entry
4. Activate the _radio button_ of the right room whose content you want to share

### Outcome

#### What did you expect?

Since the list is using _radio buttons_, I expect that only _one_ item can be selected, namely the room from "4."

#### What happened instead?

These are NOT radio buttons, although they look like it, and there were 2 rooms selected (room from "4." _and_ "2."), so I shared private content to a room with a lot of people.

![image](https://user-images.githubusercontent.com/6001248/189521440-b8b3124a-c0fd-4ca6-84ce-b960f690f871.png)

This can have fatal consequences, because you don't realize this when you make this mistake. I noticed it by coincidence, because someone asked me about it.

Since it is possible to select multiple rooms, checkboxes should be used instead of radio buttons (makes it obvious that several rooms can be selected). In addition, an indicator should be displayed somewhere to show how many rooms are selected, since it is possible that a selected room is no longer visible if it has been filtered out by the search entry.

### Your phone model

iPhone Xs

### Operating system version

iOS 16

### Application version

Element 1.9.4

### Homeserver

_No response_

### Will you send logs?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.