element-hq / element-hq/element-ios

Push rules aren't updated in the NSE when you modify them in the app.

Open
#6,451 0 comments 0 reactions 0 assignees View on GitHub
A-Notifications O-Uncommon S-Major T-Defect
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

1. Start with the default push rules that give you silent notifications for group chats:
![Screenshot 2022-07-18 at 5 08 55 pm](https://user-images.githubusercontent.com/6060466/179554837-00ca2ab5-9d27-4c23-aa7d-1ae632b8830c.png)

2. In the app go to Settings | Default Notifications and uncheck all of these, and then recheck them (forcing all to now be noisy notifications).
3. Receive a notification from a group chat.

### Outcome

#### What did you expect?
The incoming notification to now play a sound

#### What happened instead?
The notification is still silent.

A quick investigation into this and the push rules are updated in `MXNotificationCenter`, however the NSE uses `MXBackgroundPushRulesManager` and is running in a separate process.

The new rules do eventually take effect, for example if the NSE crashes or if you restart your phone.

Marked as S-Major as toggling notification sounds seems like a pretty core feature of the app to me.

### Your phone model

iPhone 12

### Operating system version

iOS 15.5

### Application version

1.8.23

### Homeserver

_No response_

### Will you send logs?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.