element-hq / element-hq/element-ios

Add a close button when leaving spaces

Open
#6,134 0 comments 0 reactions 0 assignees View on GitHub
A-Spaces T-Enhancement Z-Community-Testing
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

### Your use case

#### What would you like to do?
I think it would be great if we added an X button to the top right corner of the warning that appears when a user tries to leave a space.

![image](https://user-images.githubusercontent.com/18530109/167412692-8836dbba-dc5b-4d34-8761-eedda900d217.png)

#### Why would you like to do it?
I wanted to cancel leaving a space so I intuitively reached for the top right corner, only to realise that there's nothing there.

### Have you considered any alternatives?

The warning can actually be closed by swiping from top to bottom but I feel like there's enough room for a button.

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by locating the warning shown when a user tries to leave a space in the iOS app. Review how that warning is dismissed, then add a top-right X control that cancels leaving; done means the warning can be closed through the new button as well as the existing swipe gesture.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.