element-hq / element-hq/element-ios
Fix typos
- Dominant language
- Swift
- Stars
- 1.8k
- Forks
- 544
- PR merge metrics
- PR metrics pending
Description
I've contributed to the Swedish translation lately, and noticed a few typos in the source strings. Rather than creating a PR or issue each time I find one, I'll create this issue so we can catch a bunch of them in one go. :)
* "Space name" should probably be a dynamic reference
https://github.com/vector-im/element-ios/blob/efb1476bfbc035986c8983d5b6f9d4bcb1918cdd/Riot/Assets/en.lproj/Vector.strings#L1800-L1801
* room --> rooms
https://github.com/vector-im/element-ios/blob/efb1476bfbc035986c8983d5b6f9d4bcb1918cdd/Riot/Assets/en.lproj/Vector.strings#L934
* This is not a typo, but I need some context to what "PROMOTION" stands for. Would be nice if we could add a comment in the code explaining the string's context. Is it promotion as in "I just got a promotion in my work" or "this product is being promoted in an advertisement", or perhaps something else? (I should probably install the app and try to find the text 🧐)
https://github.com/vector-im/element-ios/blob/efb1476bfbc035986c8983d5b6f9d4bcb1918cdd/Riot/Assets/en.lproj/Vector.strings#L1802
Contributor guide
Assessment
This issue has not been assessed yet.