element-hq / element-hq/element-ios

Updating MXKAccount related settings makes settings table view jump around

Open
#5,998 0 comments 0 reactions 0 assignees View on GitHub
A-Settings O-Uncommon S-Tolerable T-Defect
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

1. Go to Settings
2. Find a setting that would update MXKAccount, for example Theme setting
3. Position this setting near the bottom of the screen
4. Modify said setting

### Outcome

#### What did you expect?

Table view standing still.

#### What happened instead?

Depending on current position, table view jumps/scrolls around. This is due to userAccount observer triggering a reloadData/reloadSections even if no data changed.

### Your phone model

Any, Simulator

### Operating system version

15.4

### Application version

develop

### Homeserver

_No response_

### Will you send logs?

No

Contributor guide

Open the contributing guide

Research direction

Start in the Settings screen and trace the userAccount observer involved when an MXKAccount setting such as Theme changes. Inspect the reloadData/reloadSections calls, then verify that changing a setting near the bottom leaves the table view stationary on iOS 15.4 or the simulator.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.