element-hq / element-hq/element-ios

Edit Message events are not correctly dealt with

Open
#5,962 1 comment 1 reaction 0 assignees View on GitHub
A-Message-Editing A-Room-List O-Frequent S-Minor T-Defect
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

I feel like there is a problem with receiving edits for other people's messages.

Steps:
1. Have another person send a message to you or a shared room
2. Let the other person edit their message

### Outcome

#### What did you expect?
To have the correct (edited) message shown in the room list as the message preview.
#### What happened instead?
- the room list shows the original message as the preview
- The notification will not get marked as read even after opening the room and reading the edited message.

See the message in the room:
![9F8D1FCB-C3F7-4999-B18F-D1C20DAC9DBE](https://user-images.githubusercontent.com/39308834/161428485-5fd85d44-e73e-4a16-ba1e-28ccc539db2a.jpeg)

See the room in the room list after opening the edited message:
![EB8B1DEC-D12C-4296-AAC0-754FCEE4F742](https://user-images.githubusercontent.com/39308834/161428459-2d56211c-b73a-4dbc-856b-e198208ff14f.jpeg)

### Your phone model

iPhone 8

### Operating system version

15.4

### Application version

Element 1.8.10 - but this was happening before

### Homeserver

Synapse 1.55.2

### Will you send logs?

No

Contributor guide

Open the contributing guide

Research direction

No source files or tests are named. Start by reproducing the edit flow on iOS, then trace how edits from other users update the room-list preview and notification read state. Done means the edited text appears in the room list and opening the room marks the notification as read.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.