element-hq / element-hq/element-ios

[MergedRoomCreationItem] DM: RoomDescriptionText use the roomName instead of memberName

Open
#5,855 0 comments 0 reactions 0 assignees View on GitHub
T-Defect
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

Steps to reproduce
Create a DM with someone and update the name of the room.
The room description text will use the room name instead of the other member name.
![Simulator Screen Shot - iPhone 12 Pro - 2022-03-17 at 14 54 17](https://user-images.githubusercontent.com/15031750/158831271-90e627f4-c7ef-4a90-8665-fbdb7d1f3017.png)

### Outcome

We should use data.memberName instead roomSummary?.displayName

### Your phone model

_No response_

### Operating system version

_No response_

### Application version

_No response_

### Homeserver

_No response_

### Will you send logs?

No

Contributor guide

Open the contributing guide

Research direction

Locate the MergedRoomCreationItem implementation and inspect how its RoomDescriptionText is built, focusing on data.memberName and roomSummary?.displayName. Reproduce the direct-message room rename scenario described in the issue, then verify that the description continues to show the other member's name rather than the renamed room name.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.