element-hq / element-hq/element-ios

`viewDidAppear` not called in `HomeViewController`

Open
#5,668 0 comments 0 reactions 0 assignees View on GitHub
A-Navigation O-Frequent S-Minor T-Defect
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

1. Put some logs in `HomeViewController.viewWillAppear()` and `HomeViewController.viewDidAppear()` method
2. open the app -> `HomeViewController.viewWillAppear()` and `HomeViewController.viewDidAppear()` is called
3. open the side menu and switch space -> Only `HomeViewController.viewWillAppear()` is called
4. Note that the parent controller methods `HomeViewControllerWithBannerWrapperViewController.viewWillAppear()` and `HomeViewControllerWithBannerWrapperViewController.viewDidAppear()` are called properly.

### Outcome

#### What did you expect?
`HomeViewController.viewDidAppear()` being called

#### What happened instead?
`HomeViewController.viewDidAppear()` is not called

### Your phone model

_No response_

### Operating system version

iOS14.4

### Application version

1.8.2

### Homeserver

_No response_

### Will you send logs?

No

Contributor guide

Open the contributing guide

Research direction

Start by locating HomeViewController and HomeViewControllerWithBannerWrapperViewController, then reproduce the lifecycle behavior by opening the side menu and switching space on iOS 14.4. Compare the parent and child appearance callbacks; done means HomeViewController.viewDidAppear() is called after switching space, as it is when opening the app.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.