element-hq / element-hq/element-ios

Update the message previews text displayed in Favourites/People/Rooms tabs

Open
#4,918 1 comment 0 reactions 0 assignees View on GitHub
X-Needs-Design Z-D1 Z-Impact-3 Z-Papercuts Z-Visibility-2
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

Following on from https://github.com/vector-im/element-ios/issues/4451, the strings displayed in the rooms lists can be unhelpful for some message types.

Media shows without any indication of the attachment type:
> **Alice:** File Name

Replies show who was replied to but no content:
> **Alice:** In reply to Bob

It would be nice to match the strings used for notifications in #4132, however it would be worth thinking about this a bit given the current sender name prefix style:

> **Alice:** replied Hello
> **Alice:** sent a Voice Message

@niquewoodhouse I think you mentioned about whether having the sender name has value in DMs for example.

**Update:** An additional message type that needs to be considered is when a room has been created but has no other events that should be displayed. Using the creation event gives the string:
> ∙ You created and configured the room.

Screenshot of these:
![IMG_0165](https://user-images.githubusercontent.com/6060466/134900886-c47aa8b0-1917-469c-b87d-5585663e1cb8.PNG)

Contributor guide

Open the contributing guide

Research direction

Start by tracing the message preview strings used in the Favourites, People, and Rooms tabs, then compare them with the notification strings referenced in #4132. Done means media previews identify the attachment type, replies include useful content, and newly created rooms have an appropriate preview.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
mobile
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.