element-hq / element-hq/element-ios
Siri Intent handler returns success on failure
- Dominant language
- Swift
- Stars
- 1.8k
- Forks
- 544
- PR merge metrics
- PR metrics pending
Description
### Steps to reproduce
Inject a direct INSendMessageIntent into the `IntentHandler.m` `handleSendMessage` function
This is the intent injected for my case:
~~~
Printing description of intent:
{
conversationIdentifier = ;
content = Issue;
sender = ;
outgoingMessageType = outgoingMessageText;
recipients = (
{
displayName = Kirstie Little;
contactIdentifier = ;
nameComponents = ;
image = ;
customIdentifier = @kirstie_little:petabyte.dev;
relationship = ;
siriMatches = ;
personHandle = {
value = @kirstie_little:petabyte.dev;
type = Unknown;
label = ;
};
},
);
speakableGroupName = ;
attachments = ;
serviceName = ;
}
~~~
### What happened?
### What did you expect?
The message get's send, or the handler returns a failure to the caller.
### What happened?
The UI returns success, but no message was send.
### Your phone model
Iphone 12
### Operating system version
15.0 (19A344)
### Application version
8510027fbf9f1fa86e9358e6480b3859375430d0-dirty
### Homeserver
matrix.org
### Have you submitted a rageshake?
No
Contributor guide
Research direction
Start in IntentHandler.m at handleSendMessage and reproduce the issue by injecting the provided INSendMessageIntent. Trace the send result and the handler response to determine why the UI reports success without sending a message. Done means failed sends are reported as failures to the caller instead of returning success.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, objective-c
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100