element-hq / element-hq/element-ios

Better support for primary colour change

Open
#4,263 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

Changing primary colour in Element still includes to modify some assets.

The following assets should be templated as much as we can:
camera_capture
![camera_capture](https://user-images.githubusercontent.com/15386762/115929661-74fa4b80-a488-11eb-8eb2-53c155e8e9be.png)
camera_video_capture
![camera_video_capture](https://user-images.githubusercontent.com/15386762/115929674-79266900-a488-11eb-8b1f-c5fa56f78907.png)
placeholder
![placeholder](https://user-images.githubusercontent.com/15386762/115929690-82afd100-a488-11eb-8b77-3345afa54d25.png)
remove_icon
![remove_icon](https://user-images.githubusercontent.com/15386762/115929695-84799480-a488-11eb-993a-7034d1ff4b4a.png)
![Element Symbol](https://user-images.githubusercontent.com/15386762/115930063-21d4c880-a489-11eb-8321-c08acb56f6f3.png)

All FAB, actions button should have the same templated background (`placeholder.png` or programmatically drawn) and the icon (templated as well) as image. Ideally, we could create a specific class for such kind of button.
This corresponds to the following assets:
![FAB](https://user-images.githubusercontent.com/15386762/115930073-24372280-a489-11eb-890c-b4fdbdc05910.png)
![Group 3144 2](https://user-images.githubusercontent.com/15386762/115930080-27321300-a489-11eb-9f40-7c31ede51d8d.png)
![Group 3144](https://user-images.githubusercontent.com/15386762/115930095-2ef1b780-a489-11eb-8e32-8c4436deeb61.png)
![save_icon](https://user-images.githubusercontent.com/15386762/115930101-32853e80-a489-11eb-8d21-5ce623d14c51.png)
![send_icon](https://user-images.githubusercontent.com/15386762/115930108-34e79880-a489-11eb-8865-8ba4e89b1ae4.png)

Also, files icon could be handled by a specific View class with 3 layers:
- the background (templated?)
![Group 3249](https://user-images.githubusercontent.com/15386762/115930847-7298f100-a48a-11eb-8401-e50ac1c42439.png)
- the frame templated
![Group 3254](https://user-images.githubusercontent.com/15386762/115930860-775da500-a48a-11eb-89dd-821b9eae71c2.png)
- the icon templated as well
![Play](https://user-images.githubusercontent.com/15386762/115930867-7af12c00-a48a-11eb-89ef-8b2f9dc1245b.png)

This corresponds to the following assets:
![file_doc_icon](https://user-images.githubusercontent.com/15386762/115930965-a70cad00-a48a-11eb-8d31-af4ad459944c.png)
![file_music_icon](https://user-images.githubusercontent.com/15386762/115930975-ab38ca80-a48a-11eb-9610-5581ebfb4a99.png)
![file_photo_icon](https://user-images.githubusercontent.com/15386762/115930987-aecc5180-a48a-11eb-9f0a-b4b126dcaf1f.png)
![file_video_icon](https://user-images.githubusercontent.com/15386762/115930995-b25fd880-a48a-11eb-828d-643067f38032.png)

Finally the favourites empty screen image may be split so we can template at least the star:
![favourites_empty_screen_artwork_dark](https://user-images.githubusercontent.com/15386762/115931145-ed620c00-a48a-11eb-9b62-8fdb853f924b.png)
![favourites_empty_screen_artwork](https://user-images.githubusercontent.com/15386762/115931154-efc46600-a48a-11eb-9c6a-24846f444186.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.