element-hq / element-hq/element-ios
MXSession.syncWithLazyLoadOfRoomMembers can be unreliable
Open
- Dominant language
- Swift
- Stars
- 1.8k
- Forks
- 544
- PR merge metrics
- PR metrics pending
Description
There can some race conditions on its value.
It can be read before its computation, which can depend on an API request in some condition.
https://github.com/matrix-org/matrix-ios-sdk/blob/v0.18.9/MatrixSDK/MXSession.m#L742-L754 is bad, for example. The MXSession can start and run while syncWithLazyLoadOfRoomMembers will be known in the future (or not if the connection fails).
This created an issue like https://github.com/vector-im/element-ios/issues/3807 but there is probably more.
Contributor guide
Assessment
This issue has not been assessed yet.