element-hq / element-hq/element-ios

Highlighted notifications are broken

Open
#4,190 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

I've noticed that missed message notifications appear unhighlighted even if I received bing messages. This bug applies for DM and non DM rooms.

Screenshot 2021-04-06 at 14 40 18

The web app displays highlighted notifications though:

Screenshot 2021-04-06 at 14 40 37

I debug a bit and the`roomSync.unreadNotifications` values in `[MXRoomSummary handleJoinedRoomSync]` are quite unexpected. I sent 2 messages with @gilutsu_test03 for exemple and the `highlighted` count is still 0:

Screenshot 2021-04-06 at 16 12 28

Contributor guide

Open the contributing guide

Research direction

Start in MXRoomSummary.handleJoinedRoomSync and inspect how roomSync.unreadNotifications supplies the highlighted count. Reproduce the case with missed messages in DM and non-DM rooms, then verify that notifications containing mentions are highlighted consistently with the web app.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.