element-hq / element-hq/element-ios
MXKEncryptionKeysImportView improvement
Open
- Dominant language
- Swift
- Stars
- 1.8k
- Forks
- 544
- PR merge metrics
- PR metrics pending
Description
`MXKEncryptionKeysImportView:showInViewController:toImportKeys:onComplete` needs the following improvements:
- The first param must be `UIViewController ` instead of `MXKViewController`
- The `onComplete` block should return the error (nullable) to let the application handle it
Contributor guide
Research direction
Start by locating the declaration of MXKEncryptionKeysImportView:showInViewController:toImportKeys:onComplete and its call sites. Review how the completion block is currently typed and invoked, then update the affected callers and verify the project builds with the protocol-based controller parameter and nullable error result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100