element-hq / element-hq/element-ios

Incorrect "cannot re-join empty room" errors

Open
#4,000 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

It appears element-ios gives errors about rejoining empty rooms, for rooms which aren't empty, and you aren't rejoining:

![image](https://user-images.githubusercontent.com/1389908/106799931-bd5b5780-6657-11eb-8c83-80336dd3c53f.png)

This was a thing that got fixed in matrix-react-sdk in https://github.com/matrix-org/matrix-react-sdk/commit/42de77e588b8bd1c854baf0313b4aaace70a4158, but it looks like that fix hasn't made it to iOS.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the referenced matrix-react-sdk commit and tracing the corresponding rejoin error handling in element-ios. Compare the conditions that produce the “cannot re-join empty room” message, then verify that the message is no longer shown for non-empty rooms or when the user is not rejoining.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.