element-hq / element-hq/element-ios

Sharing an image from Safari and Firefox result in sending a URL instead of an image.

Open
#3,951 2 comments 1 reaction 0 assignees View on GitHub
A-ShareExtension O-Occasional S-Minor T-Defect Z-WTF
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

**Describe the bug**
There are 3 different unwanted behaviors happening that might be related.

1. Sharing an image from Safari and Firefox results in sending a URL instead of an image.
~~2. Sharing an image from Apollo (the reddit client) results in sending as a file instead of an image.~~
~~3. Copying an image in Safari and Firefox then pasting into Element result in pasting a URL instead of an image.~~

**Steps to reproduce the behavior from the Share Sheet (Safari, Firefox):**
1. Go to any image in Safari
2. Press the Share button
3. Press Element
4. Select room/person
5. Image sent as a **URL** instead of an image

**Expected behavior 1**
After selecting a room/person to share to in Element, the image quality selector should come up. Then the image should be shared to Element as an image instead of a URL.

~~**To Reproduce 2**~~
~~Steps to reproduce the behavior from the Share Sheet (Apollo):~~
~~1. Go to any image in Apollo~~
~~2. Press the Share button~~
~~3. Press Element~~
~~4. Select room/person~~
~~5. Image sent as a **file** instead of an image~~

~~**To Reproduce 3**~~
~~Steps to reproduce the behavior from the clipboard:~~
~~1. Go to any image in Safari or Firefox~~
~~2. Press and hold the image~~
~~3. Press copy~~
~~4. Go to any room in Element~~
~~5. Press and hold then press paste~~

~~**Expected behavior 2**~~
~~After selecting a room/person to share to in Element, the image quality selector should come up. Then the image should be shared to Element as an image instead of a file.~~

~~**Expected behavior 3**~~
~~After pasting an image from the clipboard into Element, the image should remain an image instead of turning into a URL.~~

**Smartphone (please complete the following information):**
- Device: iPhone X
- OS: iOS 15.4.1
- Browser Safari
- Version 1.8.10

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the Share Sheet flow from Safari and Firefox on iOS: share an image to Element, select a room or person, and observe whether the result is sent as a URL. Trace the iOS share-handling entry point and verify that the completed behavior shows the image quality selector and sends an image rather than a URL.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.