element-hq / element-hq/element-ios
Move login flow management to AppCoordinator
- Dominant language
- Swift
- Stars
- 1.8k
- Forks
- 544
- PR merge metrics
- PR metrics pending
Description
TODO:
- [ ] First implement #3618
- [ ] Move login management from `-[MasterTabBarController viewDidAppear]` to `AppCoordinator.start()`
- [ ] In `AppCoordinator.start()` try do not show `SplitViewCoordinator` until login succeed. If possible try to animate transition from authentication to split view (including tab bar)
Contributor guide
Research direction
First resolve issue #3618, then read `MasterTabBarController`'s `viewDidAppear` and `AppCoordinator.start()`. Trace when `SplitViewCoordinator` is shown and how authentication completes. Done means login management starts in `AppCoordinator.start()`, the split view waits for successful login, and the authentication-to-split-view transition includes the tab bar if feasible.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- authentication, mobile-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100