element-hq / element-hq/element-ios
Remove legacy methods used to break retain cycles
Open
- Dominant language
- Swift
- Stars
- 1.8k
- Forks
- 544
- PR merge metrics
- PR metrics pending
Description
Some methods were introduced to break retain cycles. Try to remove them by analyzing dependency object graph and use weak references where needed.
Get rid of:
- [ ] `releasePushedViewController` methods
- [ ] Direct calls to `destroy` method
Contributor guide
Research direction
Start by mapping the dependency object graph around the `releasePushedViewController` methods and direct `destroy` calls. Identify where weak references are needed, then verify that both legacy method calls can be removed without reintroducing retain cycles or changing ownership behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100