element-hq / element-hq/element-ios

Push notifications don't work properly for m.rule.member_event

Open
#3,094 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

### This is a low priority issue

Was messing around with https://matrix.org/docs/spec/client_server/r0.6.0#m-rule-member-event after looking at https://github.com/vector-im/riot-web/issues/2104

Riot iOS doesn't show the correct message when the `m.rule.member_event` push rule is set like:
```
{
"conditions": [
{
"kind": "event_match",
"key": "type",
"pattern": "m.room.member"
}
],
"actions": [
"notify",
{
"set_tweak": "sound",
"value": "default"
},
{
"set_tweak": "highlight"
}
],
"rule_id": ".m.rule.member_event",
"default": true,
"enabled": true
}
```

The push notification shows User has invited you to Room no matter what the member event is.

For example this user changed their display name but Riot iOS says that I have been invited to the room
Screen Shot 2020-04-10 at 11 53 10 PM
![IMG_0874](https://user-images.githubusercontent.com/5855073/79035704-b4f4d600-7b86-11ea-9d9c-4489a7348d65.jpg)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.