element-hq / element-hq/element-ios
MXKViewControllerHandling: Remove "destroy" method
Open
- Dominant language
- Swift
- Stars
- 1.8k
- Forks
- 544
- PR merge metrics
- PR metrics pending
Description
`destroy` method was introduced as workaround to get rid of retain cycles from the outside of the class. This method can be removed by using weak references where needed.
Contributor guide
Research direction
Start by locating MXKViewControllerHandling, its destroy method, and the outside references that use it. Inspect those references for the retain-cycle workaround; done means the method and its callers are removed or replaced with weak references where needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile-dev
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100