element-hq / element-hq/element-ios

Show error when file exceeds homeserver max upload size

Open
#2,376 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

Instead of just a generic fail to send, Riot iOS should check the file size before attempting to upload it and show an error saying the file is too big and what the maximum file size is.

https://github.com/vector-im/riot-android/issues/588 is the related Android issue

> There is now an API to do this and Riot Web has implemented it. https://matrix.org/docs/spec/client_server/r0.4.0.html#get-matrix-media-r0-config
> ![Screen Shot 2019-04-19 at 8 47 06 AM](https://user-images.githubusercontent.com/5855073/56427398-55206380-6281-11e9-9cb5-b49747b06db6.png)
>
> and actually it has just recently be redesigned to look like:
> ![Screen Shot 2019-04-19 at 8 59 58 AM](https://user-images.githubusercontent.com/5855073/56427458-8d27a680-6281-11e9-9352-0d37b9d90409.png)
>
> https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/components/views/dialogs/UploadFailureDialog.js
> https://github.com/matrix-org/matrix-react-sdk/blob/e8d141fc3ca0e7ccdaa0a9901b756def64a5dd61/src/ContentMessages.js#L362

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.