element-hq / element-hq/element-ios

Room title clickable issue

Open
#2,099 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

Hi, I’m using the older version of riot(https://github.com/vector-im/riot-ios/releases/tag/v0.2.3). I can’t click the title of a room in my iPhone(iOS 12.1). I checked with the latest source in that they have added a condition for iOS > 11. I have added that condition even though I can’t click on the title.

**Newly Added Code:**

```
if (@available(iOS 11.0, *))
{
// Force the title view layout by adding 2 new constraints on the UINavigationBarContentView instance.
NSLayoutConstraint *topConstraint = [NSLayoutConstraint constraintWithItem:self
attribute:NSLayoutAttributeTop
relatedBy:NSLayoutRelationEqual
toItem:self.superview
attribute:NSLayoutAttributeTop
multiplier:1.0f
constant:0.0f];
NSLayoutConstraint *centerXConstraint = [NSLayoutConstraint constraintWithItem:self
attribute:NSLayoutAttributeCenterX
relatedBy:NSLayoutRelationEqual
toItem:self.superview
attribute:NSLayoutAttributeCenterX
multiplier:1.0f
constant:0.0f];

[NSLayoutConstraint activateConstraints:@[topConstraint, centerXConstraint]];

}
```

I have attached the screenshots of the screen, I cant open the room detail page.

![img_6498](https://user-images.githubusercontent.com/43437378/48603165-8ed00400-e99b-11e8-85c9-3f1c70e791e8.PNG)

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the room-title tap problem on iOS 12.1 using the room navigation-bar title implementation and the supplied constraint code as entry points. Confirm that tapping the title opens the room detail page; the issue is resolved when that interaction works on the affected screen.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, objective-c
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.