element-hq / element-hq/element-ios
Kill all "Block implicitly retains self" warnings
Open
code-quality
maintenance
- Dominant language
- Swift
- Stars
- 1.8k
- Forks
- 544
- PR merge metrics
- PR metrics pending
Description
This is a subset of #1859 but these warnings are important for the app stability.
Newly introduced `MXStringify` and `MXStrongify` methods should make it easier to fix.
To do in:
- [x] matrix-ios-sdk
- [ ] matrix-ios-kit
- [ ] riot-ios
Contributor guide
Research direction
Start by reviewing the parent issue #1859 and the newly introduced MXStringify and MXStrongify methods. Check the remaining "Block implicitly retains self" warnings in matrix-ios-kit and riot-ios, then confirm that those warnings are eliminated without regressions in the affected iOS targets.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100