element-hq / element-hq/element-ios
Dark theme - Improvements
- Dominant language
- Swift
- Stars
- 1.8k
- Forks
- 544
- PR merge metrics
- PR metrics pending
Description
- [x] padlock being unthemed:
- [x] some hairlines being too bright
- [x] spinner bg being white
- [x] fading behind dialog modals being white rather than dark
- [x] grey highlight bar in room list being too light (i think)?
- [x] search dialogs being wrong themed
- [x] possibly keyboard itself (can we change that)?
- [x] the keyboard bubble should be darker too
- [ ] badge text fg colour in tab bar
- [ ] fg colour in the big plus button
Contributor guide
Research direction
Start by reproducing the two unchecked dark-theme issues in the iOS app: the tab bar badge text foreground color and the large plus button foreground color. Locate the styling for those controls and verify that both use appropriate dark-theme colors; the issue is done when neither control has an incorrect light-theme foreground.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- design, mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100