element-hq / element-hq/element-ios

Layout problems in rooms when rotating

Open
#1,350 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
1.8k
Forks
544
PR merge metrics
PR metrics pending

Description

Testing Riot 0.4.0 on iPad Mini 4 running iOS 10.3.2.

These steps reproduce four problems which I'll bundle together:
* When you make a room full screen, the back button does not appear until you perform a rotate
* When you make a room full screen from portrait, messages are missing/truncated until you perform a rotate
* When you go "back" from a full screen room, both the back and full screen buttons are displayed simultaneously in the tool bar, until you either rotate or reopen the room.
* When you go "back" from full screen, you are not fully scrolled to the bottom any more.

Start off with a room in portrait mode:

![img_0022](https://user-images.githubusercontent.com/5511175/27476023-84c82e62-584a-11e7-907f-f4fd8254a9a9.PNG)

Go full screen. Note the missing back button, and the fact that everything's truncated to the left part of the screen and some messages are missing:

![img_0023](https://user-images.githubusercontent.com/5511175/27476036-8e10d2d0-584a-11e7-8ecc-16921773eeb2.PNG)

Rotate to landscape to make the messages display correctly, plus the back button:

![img_0023](https://user-images.githubusercontent.com/5511175/27476055-a2883b72-584a-11e7-8ee8-683606446dce.PNG)

Back to portrait, all fine:

![img_0025](https://user-images.githubusercontent.com/5511175/27476070-aa69013c-584a-11e7-99bc-ad839c4af22a.PNG)

Now press the back button, and I get both buttons at once in the toolbar and I am scrolled back some distance whereas I was previously at the bottom:

![img_0026](https://user-images.githubusercontent.com/5511175/27476083-b63c24d0-584a-11e7-82b2-488ca5bc5ccd.PNG)

Contributor guide

Open the contributing guide

Research direction

Reproduce the four layout and scrolling problems in a room on an iPad Mini 4 running iOS 10.3.2, following the portrait, full-screen, rotation, and back-navigation steps in the report. Trace the room view's orientation and toolbar updates, then verify that all controls, messages, and the bottom scroll position remain correct without requiring rotation.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.