element-hq / element-hq/element-android

URLs with a query param array (PHP notion) aren't detected correctly (end before the [ sign)

Open
#8,287 0 comments 0 reactions 0 assignees View on GitHub
A-Links A-Markdown O-Occasional S-Minor T-Defect
Dominant language
Kotlin
Stars
3.7k
Forks
917
PR merge metrics
No merged PRs in 30d

Description

### Steps to reproduce

1. Open a Matrix room where you can post messages
2. Post the URL https://foo.bar/?s[]=xmpp

### Outcome

#### What did you expect?

The entire URL should be clickable.
This is how websites with a PHP back end declare arrays for query params.

#### What happened instead?

* Element Android thinks the URL ends before the `[` sign.
* The clickable link becomes just `https://foo.bar/?s`.
* Element Web parses this correctly.

### Application version and app store

Element 1.5.26

### Will you send logs?

No

### Are you willing to provide a PR?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.