element-hq / element-hq/element-android

Sharing a file to using Direct Share immediately sends

Open
#8,239 0 comments 0 reactions 0 assignees View on GitHub
A-Share O-Occasional S-Tolerable T-Enhancement
Dominant language
Kotlin
Stars
3.7k
Forks
917
PR merge metrics
No merged PRs in 30d

Description

### Steps to reproduce

1. From any app, share a file (e.g., a PDF.)
2. (Inadvertently) click on any direct share room suggested in the share sheet (mostly big rooms where lots of messages are received.)
3. Accidentally send PII to a room of 6,000.

### Outcome

#### What did you expect?

I expected a confirmation screen asking me whether I am sure, like when selecting the room using the conventional share sheet entry point.

#### What happened instead?

The file was sent without explicit confirmation.

### Your phone model

Samsung S22 Ultra

### Operating system version

Android 13

### Application version and app store

Element v1.5.26

### Homeserver

_No response_

### Will you send logs?

Yes

### Are you willing to provide a PR?

Yes

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.