element-hq / element-hq/element-android

Space setting category doesn't show up

Open
#7,989 16 comments 0 reactions 0 assignees View on GitHub
O-Occasional S-Major T-Defect Z-AppLayout
Dominant language
Kotlin
Stars
3.7k
Forks
917
Avg merge
8d 20h
Merged PRs (30d)
1

Description

The space setting category doesn't show up. This blocks users from changing settings like "Show all rooms in home space". New app users cannot change this setting at all, forcing them into space filters when interacting with notifications for rooms in spaces (similar to the issue fixed in https://github.com/vector-im/element-android/pull/5827).

Here is where the visibility settings for the spaces category are defined:
https://github.com/vector-im/element-android/blob/6b98b3023e6507b211d849d14dcb167c130cd3d4/vector/src/main/java/im/vector/app/features/settings/VectorSettingsPreferencesFragment.kt#L105-L108

Here is where `isNewAppLayoutFeatureEnabled` is hardcoded to true. This causes `prefs.isVisible` to always be false.
https://github.com/vector-im/element-android/blob/6b98b3023e6507b211d849d14dcb167c130cd3d4/vector/src/main/java/im/vector/app/features/VectorFeatures.kt#L62

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.