element-hq / element-hq/element-android

Sign-up on SSO should take to sign-in

Open
#7,874 0 comments 0 reactions 0 assignees View on GitHub
A-SSO O-Uncommon S-Major T-Defect
Dominant language
Kotlin
Stars
3.7k
Forks
917
PR merge metrics
No merged PRs in 30d

Description

### Steps to reproduce

1. Open Element to the main page and choose a homeserver with `enable_registration: false` and `password_config:
enabled: false` (i.e. matrix.mit.edu)
2. Attempt to sign up

### Outcome

#### What did you expect?

It takes you to single-sign on, just like it does on the web client (https://app.element.io)

![image](https://user-images.githubusercontent.com/24363938/210184317-89affed6-0bc3-433c-a4e5-e6306cd48d69.png)

If you click on "New? Create account" it takes you directly to single-sign on

On iOS, it also works as expected, and gives you a button to sign in with single-sign on when clicking on sign up.

![image](https://user-images.githubusercontent.com/24363938/210185384-3b517099-8576-436a-bedd-c9a97ee16821.png)

#### What happened instead?

![image](https://user-images.githubusercontent.com/24363938/210184334-41593035-dc0b-45f9-ab71-f61cc68dca8e.png)

It says "registration is disabled". People may not know they're supposed to use the sign-in button instead, even if they never created an account.

### Your phone model

Pixel 6

### Operating system version

Android 13

### Application version and app store

Element version 1.5.11 [40105112] (G-40bfffae) from Play Store, olm version 3.2.12

### Homeserver

matrix-synapse-py3 1.74.0+jammy1 on Ubuntu (uplink.mit.edu)

### Will you send logs?

No

### Are you willing to provide a PR?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.