element-hq / element-hq/element-android

PagedListEpoxyController should never use the default `itemDiffCallback`

Open
#7,220 0 comments 0 reactions 0 assignees View on GitHub
A-Performance O-Frequent S-Major
Dominant language
Kotlin
Stars
3.7k
Forks
917
PR merge metrics
No merged PRs in 30d

Description

Always specify a `itemDiffCallback` in the constructor of `PagedListEpoxyController`, to ensure the performance are better, especially for the method `areItemsTheSame`. This method must compare ids and not the whole object as per the default implementation.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.