element-hq / element-hq/element-android

Edit fallback fails when edit event itself is broken

Open
#686 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
3.7k
Forks
917
PR merge metrics
No merged PRs in 30d

Description

Relates to https://github.com/matrix-org/matrix-appservice-slack/issues/322 much, where currently appservice-slack doesn't generate proper edit event towards matrix when slacker has edited an message. While that is ofcourse bug on it's own, riotX fails to show the fallback edit nor the "real" edit, resulting that user on riotX will not see any edit being done, when there is one done...

Screenshots:
riotX (see no edit nor fallback seen)
![riotX](https://user-images.githubusercontent.com/5422161/68858483-cfb54280-06ed-11ea-976a-bec51d90ff4b.jpg)
riot-android (see only fallback as nothign else is supported)
![riot-andoid](https://user-images.githubusercontent.com/5422161/68858492-d5128d00-06ed-11ea-9cb2-1d127d6ad294.jpg)
riot-web (shows fallback because actual edit event is broken, this is how riotX should show it too)
![riot-web](https://user-images.githubusercontent.com/5422161/68858465-c62bda80-06ed-11ea-9432-ac83a9fc34dd.png)

Message sources, Original message:
```
{
"type": "m.room.message",
"sender": "@slack_helsinkihacklab_:hacklab.fi",
"content": {
"body": "Turvaominaisuus, ei saa ainakaan molempia käsiä liikkuvien osien cäliin!",
"format": "org.matrix.custom.html",
"formatted_body": "Turvaominaisuus, ei saa ainakaan molempia käsiä liikkuvien osien cäliin!",
"msgtype": "m.text"
},
"event_id": "$15737336231061FYGFD:hacklab.fi",
"origin_server_ts": 1573733623423,
"unsigned": {
"age": 1125
},
"room_id": "!MjVdMmsFAxVzHUZLiV:matrix.org"
}
```

And from the edit:
```
{
"type": "m.room.message",
"sender": "@slack_helsinkihacklab_:hacklab.fi",
"content": {
"body": "(edited) ... osien cäliin! => ... osien väliin! ",
"format": "org.matrix.custom.html",
"formatted_body": "(edited) ... osien cäliin! => ... osien väliin! ",
"m.new_content": {
"body": "Turvaominaisuus, ei saa ainakaan molempia käsiä liikkuvien osien väliin!",
"format": "org.matrix.custom.html",
"formatted_body": "Turvaominaisuus, ei saa ainakaan molempia käsiä liikkuvien osien väliin!",
"msgtype": "m.text"
},
"m.relates_to": {
"rel_type": "m.replace"
},
"msgtype": "m.text"
},
"event_id": "$15737336241062ZmRbl:hacklab.fi",
"origin_server_ts": 1573733624638,
"unsigned": {
"age": 172
},
"room_id": "!MjVdMmsFAxVzHUZLiV:matrix.org"
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.