element-hq / element-hq/element-android

Autolinker does not check character types they are not allowed in IDN domain name

Open
#6,240 2 comments 0 reactions 0 assignees View on GitHub
A-Links O-Uncommon S-Minor T-Defect
Dominant language
Kotlin
Stars
3.7k
Forks
917
PR merge metrics
No merged PRs in 30d

Description

### Steps to reproduce

Send message such as `それそれ>はじめよう.みんな`
- `それそれ` is usual Japanese text.
- `>` is U+FF1E, FULLWIDTH GREATER-THAN SIGN, Often used to identify the context of a sentence.
- `はじめよう.みんな` is IDN domain name.

The words in sentence are not separated by space, it's standard in Japanese language.
But the speaker clearly separates the domain name and the sentence with `>` .

### Outcome

#### What did you expect?
In element-desktop, only `はじめよう.みんな` was autolinked. this is correct.

#### What happened instead?
In element-android, all of `それそれ>はじめよう.みんな` was autolinked.

seems Android version's autolinker does not check character types that not allowed for IDN domain name.

### Your phone model

Galaxy S10+

### Operating system version

Android 12

### Application version and app store

Element-Android 1.4.16 [40104162] (G-b8288)

### Homeserver

mastodon.juggler.jp

### Will you send logs?

No

### Are you willing to provide a PR?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.