element-hq / element-hq/element-android

HTML error messages leaking into error UI

Open
#5,956 5 comments 0 reactions 0 assignees View on GitHub
A-Onboarding T-Defect X-Needs-Product Z-FTUE
Dominant language
Kotlin
Stars
3.7k
Forks
917
Avg merge
8d 20h
Merged PRs (30d)
1

Description

### Steps to reproduce

- Select a server which responds with a 40X error (which in turn the http client library will provide an exception message containing the html body)

![94414593-C3AA-4710-A8F2-D4D6010716E9](https://user-images.githubusercontent.com/1294269/167084654-95237726-baf6-4411-8d4e-7afbc3d33c47.png)

### Outcome

#### What did you expect?

A user friendly error

#### What happened instead?

The HTML leaked

### Your phone model

_No response_

### Operating system version

_No response_

### Application version and app store

_No response_

### Homeserver

_No response_

### Will you send logs?

No

*edited by @ouchadam

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue with a server that returns a 40X response and trace the HTTP client exception into the error UI. Identify where the exception message is rendered, then verify that the UI shows a user-friendly error without the HTML body.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.