element-hq / element-hq/element-android

Manually verifying an Android client using other clients from Settings does nothing

Open
#5,914 1 comment 0 reactions 0 assignees View on GitHub
A-E2EE A-E2EE-SAS-Verification O-Uncommon S-Major T-Defect Team: Crypto
Dominant language
Kotlin
Stars
3.7k
Forks
917
Avg merge
8d 20h
Merged PRs (30d)
1

Description

### Steps to reproduce

Initial state:
- Element Web logged in with a verified account, although any other client would probably work.
- Element Android with logged in user - unverified.

1. In the Android client, go to Settings -> Security & Privacy -> Show All Sessions.
2. Tap to verify the current session.

As far as I know, this *should* already send a verification request to other devices, but tapping on 'Verify this login' doesn't seem to do anything either.

If I'm not mistaken, this happens because [here](https://github.com/vector-im/element-android/blob/0092a7057ef443a9856af62066629e3877ef194e/vector/src/main/java/im/vector/app/features/crypto/verification/VerificationBottomSheetViewModel.kt#L118) I get an empty list of verification requests, so `autoReady` is false and [this code](https://github.com/vector-im/element-android/blob/0092a7057ef443a9856af62066629e3877ef194e/vector/src/main/java/im/vector/app/features/crypto/verification/VerificationBottomSheetViewModel.kt#L160) is never called.

### Outcome

#### What did you expect?

A verification request should be sent to other logged in devices from the same user. In fact, this works fine if you verify the session right after logging in from the top banner.

#### What happened instead?

Nothing seems to be sent to other clients, I can't see anything on the several network inspectors of those clients and there are no UI changes.

### Your phone model

Emulator

### Operating system version

Android 10

### Application version and app store

1.4.14-dev [211305812] (G-8dd87321) develop

### Homeserver

matrix.org

### Will you send logs?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.