element-hq / element-hq/element-android

Quickly Resolvable Tech Debt

Open
#5,714 0 comments 0 reactions 1 assignee Claimed by @ericdecanini View on GitHub
T-Task
Dominant language
Kotlin
Stars
3.7k
Forks
917
PR merge metrics
No merged PRs in 30d

Description

These are just some minor code quality improvements discovered through conversations either on chats, while coding, or PR conversations that should be addressed where possible.

- `MessageComposerAction` includes actions that fall outside of the scope of message composition. In particular, these are concerned with audio controls and should be separated
https://github.com/vector-im/element-android/pull/5586#discussion_r843566494

- Comments in `strings.xml` should be above the corresponding line rather than beside it. This is because Weblate won't work on lines with comments
https://github.com/vector-im/element-android/pull/5586#discussion_r844935168

Feel free to add to this issue as seen fit. I'm creating this as a way for myself mostly to keep track of this debt but anyone should feel free to either add to this issue or to address the problems mentioned in it

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.