element-hq / element-hq/element-android
File names are incorrectly linkified in the message actions bottom sheet
- Dominant language
- Kotlin
- Stars
- 3.7k
- Forks
- 917
- PR merge metrics
- No merged PRs in 30d
Description
#### Describe the bug
[On this line](https://github.com/vector-im/element-android/blob/bec6cfc46dd4f790391c66434ddd066815b10153/vector/src/main/java/im/vector/app/features/home/room/detail/timeline/action/MessageActionsEpoxyController.kt#L70) (I think that's the culprit) the message body is linkified. However, the linkifier assumes too much, or isn't able to link to the correct behaviour for a shared file. See screenshot.
#### To Reproduce
Steps to reproduce the behavior:
1. Send a file with name like file_name.mov.
2. Long press the sent message to view the message actions.
3. Note that the file name is linkified.
4. Click the link.
5. Observe that the browser opens to the file name as the url, which fails to load a web page.
#### Expected behavior
Either:
- The file name is not linkified
- The linkified file name opens the file with the Android System, which can be any handler the user might have installed. In the example of the a mov file (in the screenshot), the movie could be opened in a file manager, gallery/photos app, a movie editor, etc. etc.
#### Screenshots

#### Smartphone (please complete the following information):
- Device: Pixel 3a
- OS: Android 11
#### Additional context
- App version and store: 1.1.3 [40101032] (G-b1729)
- Homeserver: matrix.org
Contributor guide
Assessment
This issue has not been assessed yet.