element-hq / element-hq/element-android

An edited reply no longer appears like a reply

Open
#2,448 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
3.7k
Forks
917
Avg merge
8d 20h
Merged PRs (30d)
1

Description

Scenario from Element web:
- I write "message"
- I reply to "message 1" with "reply to message"
- I then edit my reply so that it reads "edited reply to message"

On Element web, everything looks as expected:
![image](https://user-images.githubusercontent.com/1535823/100282936-d0bdb880-2f6c-11eb-8b91-47306f7d4678.png)

On Element Android, as soon as the reply is edited, it no longer displays like a reply.
![image](https://user-images.githubusercontent.com/1535823/100282964-e03d0180-2f6c-11eb-8d1d-2bbb79cde74e.png)
becomes:
![image](https://user-images.githubusercontent.com/1535823/100282988-eaf79680-2f6c-11eb-9d28-f7dd1efd6b5f.png)

This can easily lead to misunderstandings...

**Smartphone (please complete the following information):**
- Device: OnePlus 5
- OS: Android 10
(Also reproduced on a another Samsung phone with an unknown Android version)

**Additional context**
- version 1.0.10 from Google Play
- Homeserver: my own instance: matrix.x2a.yt (v1.21.1)

---

For completeness, here are the events:

"message":
```json
{
"type": "m.room.message",
"sender": "@melvyn:matrix.x2a.yt",
"content": {
"msgtype": "m.text",
"body": "message"
},
"origin_server_ts": 1606339246889,
"unsigned": {
"age": 380,
"transaction_id": "m1606339247502.0"
},
"event_id": "$aM1QpxbL602Q3mvOgdyF6P9vPSf-q6shuh_rDRGKSHY",
"room_id": "!fWdGIZqZmXaMQRXsWl:matrix.x2a.yt"
}
```

"reply to message":
```json
{
"type": "m.room.message",
"room_id": "!fWdGIZqZmXaMQRXsWl:matrix.x2a.yt",
"sender": "@melvyn:matrix.x2a.yt",
"content": {
"msgtype": "m.text",
"body": "> <@melvyn:matrix.x2a.yt> message\n\nreply to message",
"format": "org.matrix.custom.html",
"formatted_body": "

In reply to @melvyn:matrix.x2a.yt
message
reply to message",
"m.relates_to": {
"m.in_reply_to": {
"event_id": "$aM1QpxbL602Q3mvOgdyF6P9vPSf-q6shuh_rDRGKSHY"
}
}
},
"origin_server_ts": 1606339266463,
"unsigned": {
"age": 516062
},
"event_id": "$cqLdTZlHg6QBQZ19PzQP_oVBVHsrglk4eAMtxfj8m24",
"user_id": "@melvyn:matrix.x2a.yt",
"age": 516062
}
```

"edited reply to message":
```json
{
"type": "m.room.message",
"room_id": "!fWdGIZqZmXaMQRXsWl:matrix.x2a.yt",
"sender": "@melvyn:matrix.x2a.yt",
"content": {
"m.new_content": {
"msgtype": "m.text",
"body": "edited reply to message",
"format": "org.matrix.custom.html",
"formatted_body": "edited reply to message"
},
"m.relates_to": {
"rel_type": "m.replace",
"event_id": "$cqLdTZlHg6QBQZ19PzQP_oVBVHsrglk4eAMtxfj8m24"
},
"msgtype": "m.text",
"body": "> <@melvyn:matrix.x2a.yt> message\n\n * edited reply to message",
"format": "org.matrix.custom.html",
"formatted_body": "

In reply to @melvyn:matrix.x2a.yt
message
* edited reply to message"
},
"origin_server_ts": 1606339290227,
"unsigned": {
"age": 524206
},
"event_id": "$det6JWBsxcIgLhNibDTBjztEPpQJk5w6MqMDodhvZtc",
"user_id": "@melvyn:matrix.x2a.yt",
"age": 524206
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.