element-hq / element-hq/element-android

Taken photo is lost if the phone was rotated

Open
#2,046 5 comments 0 reactions 0 assignees View on GitHub
A-Media O-Occasional S-Major T-Defect
Dominant language
Kotlin
Stars
3.7k
Forks
917
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
If the phone was physically turned 90° after starting the camera and not turned back then the taken image will be lost and no upload dialog displayed

**To Reproduce**
Steps to reproduce the behavior:
1. Hold the phone vertically (portrait)
2. Press the + button and choose `Camera`
3. Turn the phone horizontally (landscape)
4. Take a photo
5. The room activity seems to restart and the taken photo is lost, no upload dialog displayed

**Expected behavior**
Should show the upload dialog, some moments in life can not be recreated and thus lost forever because of this bug.

**Smartphone (please complete the following information):**
- Device: Moto G7 Power
- OS: Android 10

**Additional context**
- 1.0.5 [40100052] (G-b3529)
- Homeserver: own

Similar issue from the old Riot Android: vector-im/riot-android#1510
Depending on the camera app, if you turn the phone back _after_ taking a shot but _before_ confirming it the activity doesn't restart and the dialog appears as expected.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.