element-hq / element-hq/element-android

Indicate who an image will be shared with, prior to sending, when using the "share with" flow

Open
#1,659 0 comments 3 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
3.7k
Forks
917
PR merge metrics
No merged PRs in 30d

Description

Hi all,

Currently, when I share an image using the share-with thing to RiotX, it will

- prompt me for the chat to share with, showing me the list of most recent chats (I guess)

- then show me the "edit picture" screen, after which the next step is sharing the image with the send button

![a6445aa0-6778-4d1b-a554-4411458c4191](https://user-images.githubusercontent.com/16254070/87151658-89cc7080-c2b4-11ea-8943-d499ee5dbd00.png)

**Issue**

The issue I have with the above flow is that when you *quickly* just tap on an entry in the list of conversations, I'm sometimes not sure that I pressed the right one or whether I missed. On the last screen I see above, I can't see who the image is actually going to be sent to. This could lead to sending a picture to the wrong people. To be sure, I have to move slowly through the share-with flow, or share files from within a conversation (instead of from an image).

**Proposal**

Ideally, I'd like some indication on the screen above about where the file is going to be shared to. I think most of the messengers I use do this (for example conversations). Mock-up example:

![edit](https://user-images.githubusercontent.com/16254070/87152010-2ee74900-c2b5-11ea-9192-e41fb7ff0438.png)

How conversation does it:

![84dd55bb-93ac-4334-85c6-4ecafb3419de](https://user-images.githubusercontent.com/16254070/87152417-f136f000-c2b5-11ea-8502-9bbf219849a3.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.