element-hq / element-hq/dendrite
We should not use depth in the sync API
- Dominant language
- Go
- Stars
- 965
- Forks
- 101
- PR merge metrics
- No merged PRs in 30d
Description
*This issue was originally created by [**@neilalexander**](https://github.com/neilalexander) at .*
Currently the sync API uses the event depth when inserting events into the topology, which we should really not do since depth is deprecated.
(Incidentally, we probably need to come up with some better way to maintain topological ordering with inserts.)
Contributor guide
Research direction
Trace the sync API path that inserts events into the topology and identify where event depth is used. Review the surrounding topology-ordering logic and existing tests, if present. Done means the sync API no longer relies on deprecated depth while preserving correct topological ordering; the issue also notes that a better ordering approach may be needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend-api-design, distributed-systems
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100