element-hq / element-hq/dendrite

/invite API does not fill displayname field

Open
#3,492 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

T-Defect
Dominant language
Go
Stars
967
Forks
102
PR merge metrics
No merged PRs in 30d

Description

Background information
  • Dendrite version or git SHA: dendrite-demo-pinecone:main
  • SQLite3 or Postgres?: sqlite3
  • Running in Docker?: yes
  • go version: dendrite-demo-pinecone:main
  • Client used (if applicable): element-web
Description
  • What is the problem: DM rooms with pending invites show up with a userId instead of display name
  • Who is affected: Most people seemingly
  • How is this bug manifesting: /sync returns less helpful data
  • When did this first appear: Unclear
Steps to reproduce
  • Invite an existing user with a display name
  • Observe your invite event has no displayname field

The spec does not explicitly say to do this, maybe it ought to. Synapse does this. Without this invites are significantly more confusing to the end user given that they may have invited via the User Directory graphically, so never saw the MXID, now only see the MXID until the user joins.

SynapseTrace.zip
DendriteTrace.zip

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the /invite API handling path and compare the resulting pending-invite event in /sync with Synapse’s behavior; the attached Dendrite and Synapse traces are the available evidence. Confirm that an existing user’s display name is included in the invite data, then verify the reproduction steps no longer show only the MXID.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, sqlite
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.