element-hq / element-hq/dendrite

Dendrite never listens on -https-bind-address :443 -http-bind-address :80, never fails either

Open
#3,434 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
965
Forks
101
PR merge metrics
No merged PRs in 30d

Description

*This issue was originally created by [**@paigeadelethompson**](https://github.com/paigeadelethompson) at .*

When these options are specified, there should be an expectation that this condition is reached:

```
time="2024-09-28T13:00:36.332861661Z" level=info msg="Starting external listener on :80"
time="2024-09-28T13:00:36.333589366Z" level=info msg="Starting external listener on :443"
```

if not then it should be fatal, and it shouldn't be doing anything else.

Contributor guide

Open the contributing guide

Research direction

Start by tracing how -https-bind-address and -http-bind-address are parsed and how the external listeners are started. Reproduce with :443 and :80, then verify that both listeners start as logged or that startup fails fatally instead of continuing.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.